[testdata]: Add ambiguous golden answers - #180
Closed
luke-hill wants to merge 1 commit into
Closed
Conversation
davidjgoss
reviewed
Jul 1, 2026
davidjgoss
left a comment
davidjgoss
left a comment
Member
There was a problem hiding this comment.
This is missing a change to add ambiguous to the allow list of samples to test and regenerate.
- java https://github.com/cucumber/query/blob/main/java/src/test/java/io/cucumber/query/QueryAcceptanceTest.java#L101
- javascript https://github.com/cucumber/query/blob/main/javascript/src/acceptance.spec.ts#L24
- dotnet https://github.com/cucumber/query/blob/main/dotnet/Cucumber.QueryTest/QueryAcceptanceTest.cs#L15
Contributor
Author
|
@davidjgoss Assuming those languages are utilising the full suite, this would break them currently. I can add that change at the end of this PR once I've fixed up all 42 files (Atm only 6 of them I've confirmed to be correct). |
luke-hill
marked this pull request as draft
July 1, 2026 08:24
Member
|
@luke-hill what code does this cover that isn't already covered by the existing test cases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
WIP: Adds another cck example that has valid answers to be asserted upon
⚡️ What's your motivation?
Allows more of the CCK to be tested
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
6/42 files correct
findAllPickles/findAllTestCases/findAllTestSteps/findTestCaseBy/findTestStepBy/findPickleByThis text was originally generated from a template, then edited by hand. You can modify the template here.